Messages in this thread | | | From | Prabhakar Lad <> | Date | Thu, 23 May 2013 15:11:36 +0530 | Subject | Re: [PATCH 3/5] media: i2c: tvp7002: rearrange header inclusion alphabetically |
| |
Hi Hans,
On Thu, May 23, 2013 at 3:05 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote: > On Tue 14 May 2013 12:45:32 Lad Prabhakar wrote: >> From: Lad, Prabhakar <prabhakar.csengg@gmail.com> >> >> This patch rearranges the header inclusion alphabetically >> and also removes unnecessary includes. > > As Laurent mentioned in a review for another patch (vpif) you probably > shouldn't remove these headers. videodev2.h is certainly used, as is slab.h > and v4l2-common.h. In the past removing slab.h causes problems on other > architectures where that header isn't automatically included by other > headers. > OK
> I would just drop this patch. I've merged the first two patches of > this patch series, the last two I can't merge as long as the async > code isn't in yet. > Thanks. yes the last two depend on v4l-async patches.
Regards, --Prabhakar Lad
| |