lkml.org 
[lkml]   [2013]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface
On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote:
> >> + notify_remote_via_evtchn(priv->evtchn);
> >> +
> >> + ordinal = be32_to_cpu(*((__be32 *) (buf + 6)));
> >
> > Um, + 6? Why? Is there an #define for that magic constant?
> > Should this value be read before you do the wait_for_tpm_stat stuff?
>
> This is hardcoded to 6 even in tpm.c. Time for a #define...
>
> > Otherwise it looks OK to me. Should this go through me or Kent?
> > And if so, is Kent waiting for my feedback?
>
> My comments were minor -- I was expecting feedback on your earlier
> comments before merging. I think this should go through the tpmdd
> maintainer if its going to live in drivers/char/tpm though.

That is you I thought?

konrad@phenom:~/mm$ scripts/get_maintainer.pl -f drivers/char/tpm
Kent Yoder <key@linux.vnet.ibm.com> (maintainer:TPM DEVICE DRIVER)
Rajiv Andrade <mail@srajiv.net> (maintainer:TPM DEVICE DRIVER)
Marcel Selhorst <tpmdd@selhorst.net> (maintainer:TPM DEVICE DRIVER)
Sirrix AG <tpmdd@sirrix.com> (maintainer:TPM DEVICE DRIVER)
tpmdd-devel@lists.sourceforge.net (moderated list:TPM DEVICE DRIVER)
linux-kernel@vger.kernel.org (open list)


\
 
 \ /
  Last update: 2013-05-22 23:41    [W:0.374 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site