lkml.org 
[lkml]   [2013]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3 4/5] gpio-langwell: amend error messages
Date
There is no need to use hardcoded device name in the error messages, because
dev_err() prefixes the message with the device name anyway.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/gpio/gpio-langwell.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio/gpio-langwell.c
index 54b6caf..313d190 100644
--- a/drivers/gpio/gpio-langwell.c
+++ b/drivers/gpio/gpio-langwell.c
@@ -347,7 +347,7 @@ static int lnw_gpio_probe(struct pci_dev *pdev,

lnw = devm_kzalloc(&pdev->dev, sizeof(*lnw), GFP_KERNEL);
if (!lnw) {
- dev_err(&pdev->dev, "can't allocate langwell_gpio chip data\n");
+ dev_err(&pdev->dev, "can't allocate chip data\n");
return -ENOMEM;
}

@@ -374,7 +374,7 @@ static int lnw_gpio_probe(struct pci_dev *pdev,
pci_set_drvdata(pdev, lnw);
retval = gpiochip_add(&lnw->chip);
if (retval) {
- dev_err(&pdev->dev, "langwell gpiochip_add error %d\n", retval);
+ dev_err(&pdev->dev, "gpiochip_add error %d\n", retval);
return retval;
}

@@ -408,8 +408,7 @@ static int wp_gpio_probe(struct platform_device *pdev)

lnw = devm_kzalloc(&pdev->dev, sizeof(struct lnw_gpio), GFP_KERNEL);
if (!lnw) {
- dev_err(&pdev->dev,
- "can't allocate whitneypoint_gpio chip data\n");
+ dev_err(&pdev->dev, "can't allocate chip data\n");
return -ENOMEM;
}

@@ -432,8 +431,7 @@ static int wp_gpio_probe(struct platform_device *pdev)
gc->can_sleep = 0;
retval = gpiochip_add(gc);
if (retval) {
- dev_err(&pdev->dev, "whitneypoint gpiochip_add error %d\n",
- retval);
+ dev_err(&pdev->dev, "gpiochip_add error %d\n", retval);
return retval;
}
platform_set_drvdata(pdev, lnw);
--
1.8.2.rc0.22.gb3600c3


\
 
 \ /
  Last update: 2013-05-22 13:01    [W:0.077 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site