Messages in this thread | | | Date | Wed, 22 May 2013 17:24:37 +0800 | From | Tang Chen <> | Subject | Re: [PATCH v2 01/13] x86: get pg_data_t's memory from other node |
| |
On 05/22/2013 04:55 PM, Chen Gong wrote: ...... >> - nd_pa = memblock_alloc_nid(nd_size, SMP_CACHE_BYTES, nid); >> + nd_pa = memblock_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid); > > go through the implementation of memblock_alloc_try_nid, it will call > panic when allocation fails(a.k.a alloc = 0), if so, below information > will be never printed. Do we really need this?
Oh, yes.
We don't need this. Will remove the following in the next version.
Thanks. :)
> >> if (!nd_pa) { >> - pr_err("Cannot find %zu bytes in node %d\n", >> - nd_size, nid); >> + pr_err("Cannot find %zu bytes in any node\n", nd_size); >> return; >> } >> nd = __va(nd_pa); >> -- >> 1.7.1 >> >> -- >> To unsubscribe, send a message with 'unsubscribe linux-mm' in >> the body to majordomo@kvack.org. For more info on Linux MM, >> see: http://www.linux-mm.org/ . >> Don't email:<a href=mailto:"dont@kvack.org"> email@kvack.org</a>
| |