Messages in this thread | | | Date | Tue, 21 May 2013 15:02:59 -0700 | From | John Stultz <> | Subject | Re: [PATCH 3/4] rtc: rtc-hid-sensor-time: add option hctosys to set time at boot |
| |
On 05/05/2013 04:21 AM, Alexander Holler wrote: > drivers/rtc/hctosys (CONFIG_RTC_HCTOSYS) doesn't work for > rtc-hid-sensor-time because it will be called in late_init, and thus before > rtc-hid-sensor-time gets loaded. To set the time through > rtc-hid-sensor-time at startup, the module now checks by default if the > system time is before 1970-01-02 and sets the system time (once) if this is > the case. > > To disable this behaviour, set the module option hctosys to zero, e.g. by > using rtc-hid-sensor-time.hctosys=0 at the kernel command line if the > driver is statically linked into the kernel.
Sorry I missed this earlier, it fell into my spam box for some reason.
Like Andrew, I think this feels particularly hacky.
Why exactly is late_init too early? (I'm unfamiliar with the rtc-hid-sensor-time driver)
If this is a hotplug rtc device (why I'm guessing its not available at late_init), would it not be better to leave the setting of time using hwclock --hctosys via a udev rule or something?
thanks -john
| |