lkml.org 
[lkml]   [2013]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] ARM: smp: Drop RCU_NONIDLE usage in cpu_die()
    Date
    Before f7b861b (arm: Use generic idle loop, 2013-03-21) ARM would
    kill the CPU within the rcu idle section. Now that the
    rcu_idle_enter()/exit() pair have been pushed lower down in the
    idle loop this is no longer true and so using RCU_NONIDLE here is
    no longer necessary and also harmful because RCU is not actually
    idle at this point.

    Cc: Russell King <linux@arm.linux.org.uk>
    Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
    ---
    arch/arm/kernel/smp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
    index 4619177..78f1eb5 100644
    --- a/arch/arm/kernel/smp.c
    +++ b/arch/arm/kernel/smp.c
    @@ -233,7 +233,7 @@ void __ref cpu_die(void)
    mb();

    /* Tell __cpu_die() that this CPU is now safe to dispose of */
    - RCU_NONIDLE(complete(&cpu_died));
    + complete(&cpu_died);

    /*
    * actual CPU shutdown procedure is at least platform (if not
    --
    The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
    hosted by The Linux Foundation


    \
     
     \ /
      Last update: 2013-05-21 03:21    [W:7.430 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site