lkml.org 
[lkml]   [2013]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/5] perf: net_dropmonitor: Fix symbol-relative addresses
    From
    Date
    The comparison between traced and symbol addresses is backwards: if
    the traced address doesn't exactly match a symbol (which we don't
    expect it to), we'll show the next symbol and the offset to it,
    whereas we should show the previous symbol and the offset from it.

    Cc: stable@vger.kernel.org
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    tools/perf/scripts/python/net_dropmonitor.py | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/tools/perf/scripts/python/net_dropmonitor.py b/tools/perf/scripts/python/net_dropmonitor.py
    index adbfbf0..4c11605 100755
    --- a/tools/perf/scripts/python/net_dropmonitor.py
    +++ b/tools/perf/scripts/python/net_dropmonitor.py
    @@ -40,9 +40,9 @@ def get_kallsyms_table():

    def get_sym(sloc):
    loc = int(sloc)
    - for i in kallsyms:
    - if (i['loc'] >= loc):
    - return (i['name'], i['loc']-loc)
    + for i in kallsyms[::-1]:
    + if loc >= i['loc']:
    + return (i['name'], loc - i['loc'])
    return (None, 0)

    def print_drop_table():

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2013-05-21 03:21    [W:9.358 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site