Messages in this thread | | | Date | Mon, 20 May 2013 11:13:29 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] Revert "x86-64, init: Do not set NX bits on non-NX capable hardware" |
| |
On 05/20/2013 10:21 AM, Linus Torvalds wrote: > On Mon, May 20, 2013 at 9:43 AM, Michal Hocko <mhocko@suse.cz> wrote: >> >> The configuration has been posted in the referenced thread: >> https://lkml.org/lkml/2013/5/14/398 > > Hmm. That's a regular intel i5 Sandybridge CPU. Which certainly has NX. > > Hmm. secondary_startup_64 isn't __initcode, is it? I think it's used > for resuming the other CPU's too and for CPU hotplug. Yes/no? > > If so early_pmd_flags shouldn't be __initdata, I think. > > Michal, does it work if you don't do the revert, but just remove the > __initdata instead? >
Indeed. Looks like we corrupt a random bit in memory on resume.
-hpa
| |