lkml.org 
[lkml]   [2013]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] gpio: mcp23s08: Fix build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m
From
On Sun, May 19, 2013 at 1:11 PM, Axel Lin <axel.lin@ingics.com> wrote:

> This patch fixes below build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m &&
> CONFIG_GPIO_MCP23S08=y.
>
> LD init/built-in.o
> drivers/built-in.o: In function `mcp23017_write':
> clkdev.c:(.text+0x1e14): undefined reference to `i2c_smbus_write_word_data'
> drivers/built-in.o: In function `mcp23017_read':
> clkdev.c:(.text+0x1e24): undefined reference to `i2c_smbus_read_word_data'
> drivers/built-in.o: In function `mcp23008_write':
> clkdev.c:(.text+0x1e8c): undefined reference to `i2c_smbus_write_byte_data'
> drivers/built-in.o: In function `mcp23008_read':
> clkdev.c:(.text+0x1e98): undefined reference to `i2c_smbus_read_byte_data'
> drivers/built-in.o: In function `mcp23008_read_regs':
> clkdev.c:(.text+0x1ed0): undefined reference to `i2c_smbus_read_byte_data'
> drivers/built-in.o: In function `mcp23s08_init':
> clkdev.c:(.init.text+0x30): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `mcp23s08_exit':
> clkdev.c:(.exit.text+0x30): undefined reference to `i2c_del_driver'
> make: *** [vmlinux] Error 1
>
> When CONFIG_I2C=m, meaning we can't build the drivers in with I2C support.
> Thus don't allow the drivers to be compiled as built-in when CONFIG_I2C=m.
>
> The real fix though is to break the driver apart into a SPI part, an I2C part
> and a common part. But that's something for 3.11 while this is something for
> 3.10/stable.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Applied for fixes with Andy's ACK.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-05-20 19:41    [W:0.067 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site