Messages in this thread | | | Date | Mon, 20 May 2013 09:58:39 +0300 (EEST) | From | Petko Manolov <> | Subject | Re: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup |
| |
On Sun, 19 May 2013, Francois Romieu wrote:
> Which one ? > - share it through the kernel or with userspace > - personal choice .c split
It is obviously not the former. I think that in general constant and other definitions (in their majority) should be in a header file. I definitely like this way better.
Perhaps in this particular case my patch is a bit of an overkill as the code lines aren't that many. If the consensus is in this direction i'll revert this part of the series.
> I don't mind the later even if it does not exactly apply to a > WIP driver. I'd still avoid future copycat followers though.
This isn't WIP anymore as the W(ork) part is missing. After so many quiet years i assume the experimental tag should be removed.
> The rtl8150.h file is created in patch #2. This is patch #1. > > So...
So first apply patch #1 and then patch #2.
However, if it is required for the driver to be in build-able form after applying any single patch i'll coalesce #1 and #2 before next submission.
David?
Petko
| |