lkml.org 
[lkml]   [2013]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 4/6] KVM: MMU: fast invalid all shadow pages
    On Sat, 27 Apr 2013 11:13:20 +0800
    Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> wrote:

    > +/*
    > + * Fast invalid all shadow pages belong to @slot.
    > + *
    > + * @slot != NULL means the invalidation is caused the memslot specified
    > + * by @slot is being deleted, in this case, we should ensure that rmap
    > + * and lpage-info of the @slot can not be used after calling the function.
    > + *
    > + * @slot == NULL means the invalidation due to other reasons, we need

    The comment should explain what the "other reasons" are.
    But this API may better be split into two separate functions; it depends
    on the "other reasons".

    > + * not care rmap and lpage-info since they are still valid after calling
    > + * the function.
    > + */
    > +void kvm_mmu_invalid_memslot_pages(struct kvm *kvm,
    > + struct kvm_memory_slot *slot)

    You yourself is explaining this as "invalidation" in the comment.
    kvm_mmu_invalidate_shadow_pages_memslot() or something...

    Anybody can think of a better name?

    Takuya


    \
     
     \ /
      Last update: 2013-05-03 04:41    [W:3.069 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site