Messages in this thread | | | Date | Thu, 2 May 2013 17:10:26 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH v2 00/10] optimize freezing tasks by reducing task wakeups |
| |
Hey, Rafael.
On Thu, May 02, 2013 at 11:06:35PM +0200, Rafael J. Wysocki wrote: > > v2 moves the skip check to freeze_task(), and expands the commit > > messages. > > The entire series makes sense to me, so are there any objections? > > Tejun, Oleg??
Generally looks good to me. I'm a bit uncomfortable with the generic-looking expansion of the freezable API as it can't be something which can be used in any generic manner. It'd be great if we just add only the used ones (do we already?) and add some sort of lockdep annotation so that people don't use them while holding any locks.
Thanks.
-- tejun
| |