lkml.org 
[lkml]   [2013]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] NOHZ, check to see if tick device is initialized in IRQ handling path
From
>  void tick_nohz_irq_exit(void)
> {
> struct tick_sched *ts = &__get_cpu_var(tick_cpu_sched);
> + struct clock_event_device *dev =
> + __get_cpu_var(tick_cpu_device).evtdev;
> +
> + /* Has the tick been initialized yet? */
> + if (unlikely(!dev || dev->mode == CLOCK_EVT_MODE_UNUSED))
> + return;

Could we have something in the "struct tick_sched" to tell us whether
it has been set up? Rather than this somewhat convoluted digging
around in the clock_event_device innards?

> + if (unlikely(!dev || dev->mode == CLOCK_EVT_MODE_UNUSED))
> + return;

Ditto here.

-Tony


\
 
 \ /
  Last update: 2013-05-03 01:21    [W:0.072 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site