lkml.org 
[lkml]   [2013]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()
Date
Hi Axel,

Thank you for the patch.

On Sunday 19 May 2013 13:45:31 Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-renesas-tpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
> index 8e6d8d7..351addd 100644
> --- a/drivers/pwm/pwm-renesas-tpu.c
> +++ b/drivers/pwm/pwm-renesas-tpu.c
> @@ -444,7 +444,7 @@ static int tpu_remove(struct platform_device *pdev)
>
> pm_runtime_disable(&pdev->dev);
>
> - return 0;
> + return pwmchip_remove(&tpu->chip);

Could you please move that line at the beginning of the function ? There would
be a race condition otherwise, as the user could reenable PWM between the
tpu_pwm_timer_stop() calls and the pwmchip_remove() call.

Apart from that, the patch looks good.

> }
>
> static struct platform_driver tpu_driver = {

--
Regards,

Laurent Pinchart



\
 
 \ /
  Last update: 2013-05-19 16:41    [W:0.037 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site