lkml.org 
[lkml]   [2013]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] drivers: net: usb: rtl8150: bug fixing and cleanup
On Sat, 18 May 2013, Francois Romieu wrote:

> Petko Manolov <petkan@nucleusys.com> :
> [...]
> > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> > index 7d1897b..fd4bc2a 100644
> > --- a/drivers/net/usb/rtl8150.c
> > +++ b/drivers/net/usb/rtl8150.c
> [...]
> > static void rx_fixup(unsigned long data)
> > {
> > struct rtl8150 *dev = (struct rtl8150 *)data;
> > struct sk_buff *skb;
> > int status;
> >
> > - spin_lock_irq(&dev->rx_pool_lock);
> > - fill_skb_pool(dev);
> > - spin_unlock_irq(&dev->rx_pool_lock);
> > if (test_bit(RX_URB_FAIL, &dev->flags))
> > if (dev->rx_skb)
> > goto try_again;
> > - spin_lock_irq(&dev->rx_pool_lock);
> > - skb = pull_skb(dev);
> > - spin_unlock_irq(&dev->rx_pool_lock);
> > + skb = __netdev_alloc_skb_ip_align(dev->netdev, RTL8150_MTU, GFP_ATOMIC);
>
> You can use plain netdev_alloc_skb_ip_align.

Yep, except for the call in rtl8150_open() (where GFP_KERNEL is more
appropriate) i should have used the plain version.


\
 
 \ /
  Last update: 2013-05-19 11:01    [W:0.039 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site