Messages in this thread Patch in this message | | | Date | Mon, 20 May 2013 09:34:26 +0800 | From | Libo Chen <> | Subject | [PATCH] cdrom: gdrom: fix device number leak |
| |
"repost with Jens Axboe <axboe@kernel.dk> added" suggest by Tejun Heo <tj@kernel.org>
without this patch, gdrom_major will leak when gd.cd_info alloc faild
Signed-off-by: Libo Chen <libo.chen@huawei.com> --- drivers/cdrom/gdrom.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c index 4afcb65..5980cb9 100644 --- a/drivers/cdrom/gdrom.c +++ b/drivers/cdrom/gdrom.c @@ -830,9 +830,9 @@ probe_fail_cdrom_register: del_gendisk(gd.disk); probe_fail_no_disk: kfree(gd.cd_info); +probe_fail_no_mem: unregister_blkdev(gdrom_major, GDROM_DEV_NAME); gdrom_major = 0; -probe_fail_no_mem: pr_warning("Probe failed - error is 0x%X\n", err); return err; } -- 1.7.1
| |