Messages in this thread | | | From | Leon Romanovsky <> | Date | Fri, 17 May 2013 20:50:36 +0300 | Subject | Re: [PATCH] drivers: mfd: sec-code: Fix sizeof argument |
| |
On Fri, May 17, 2013 at 1:13 AM, Samuel Ortiz <sameo@linux.intel.com> wrote: > Hi Leon, > > On Wed, May 15, 2013 at 01:53:56PM +0300, Leon Romanovsky wrote: >> Signed-off-by: Leon Romanovsky <leon@leon.nu> >> --- >> drivers/mfd/sec-core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c >> index 77ee26ef..5b740a3 100644 >> --- a/drivers/mfd/sec-core.c >> +++ b/drivers/mfd/sec-core.c >> @@ -121,7 +121,7 @@ static struct sec_platform_data *sec_pmic_i2c_parse_dt_pdata( >> { >> struct sec_platform_data *pd; >> >> - pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); >> + pd = devm_kzalloc(dev, sizeof(struct sec_platform_data), GFP_KERNEL); > How is that fixing anything ? Technically you are right, this fix brings code to be align to common code convention and allows to automatic tools correctly parse it.
> > Cheers, > Samuel. > > -- > Intel Open Source Technology Centre > http://oss.intel.com/
-- Leon Romanovsky | Independent Linux Consultant www.leon.nu | leon@leon.nu
| |