lkml.org 
[lkml]   [2013]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] Initial support for Allwinner's Security ID fuses
    Date
    On Friday 17 May 2013 15:35:43 Oliver Schinagl wrote:
    > +static struct bin_attribute sid_bin_attr = {
    > + .attr = {
    > + .name = "key",
    > + .mode = S_IRUGO,
    > + },
    > + .size = SUNXI_SID_SIZE,
    > + .read = sid_read,
    > +};

    I believe all the other drivers in drivers/misc/eeprom use "eeprom"
    as the name for the attribute, so using "key" here is a bit inconsistent.

    Can you change that?

    Arnd


    \
     
     \ /
      Last update: 2013-05-17 16:21    [W:2.608 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site