lkml.org 
[lkml]   [2013]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] usb: ohci: fix goto wrong tag in err case
On Thu, May 09, 2013 at 12:58:10PM +0800, Libo Chen wrote:
> From: Libo Chen <chenlibo.3@gmail.com>
>
> fix goto wrong tag in usb_hcd_nxp_probe
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
> drivers/usb/host/ohci-nxp.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> index f4988fb..eb294a9 100644
> --- a/drivers/usb/host/ohci-nxp.c
> +++ b/drivers/usb/host/ohci-nxp.c
> @@ -234,7 +234,7 @@ static int usb_hcd_nxp_probe(struct platform_device *pdev)
> if (usb_disabled()) {
> dev_err(&pdev->dev, "USB is disabled\n");
> ret = -ENODEV;
> - goto out;
> + goto out1;

Please fix this up to use better error case names so this does not
happen again.

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-05-17 06:41    [W:0.153 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site