Messages in this thread | | | Date | Thu, 16 May 2013 20:21:07 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH v6 0/8] kdump, vmcore: support mmap() on /proc/vmcore |
| |
On 05/16/2013 07:53 PM, Eric W. Biederman wrote: > > That is completely and totally orthogonal to this change. > > read_oldmem may have problems but in practice on a large systems those > problems are totally dwarfed by real life performance issues that come > from playing too much with the page tables. > > I really don't find bringing up whatever foundational issues you have > with read_oldmem() appropriate or relevant here. >
Well, it is in the sense that we have two pieces of code doing the same thing, each with different bugs.
-hpa
| |