Messages in this thread | | | From | Rusty Russell <> | Subject | Re: V3.10-rc1 memory leak | Date | Fri, 17 May 2013 09:17:12 +0930 |
| |
Catalin Marinas <catalin.marinas@arm.com> writes:
> On Wed, May 15, 2013 at 08:33:01PM +0100, Steven Rostedt wrote: >> On Wed, 2013-05-15 at 15:37 +0100, Catalin Marinas wrote: >> >> > >From 0621c7e1909ea86bf8499a0ffe5ea59d1007ee8c Mon Sep 17 00:00:00 2001 >> > From: Catalin Marinas <catalin.marinas@arm.com> >> > Date: Wed, 15 May 2013 15:30:46 +0100 >> > Subject: [PATCH] kmemleak: Scan the jump label module section >> > >> > Objects allocated in jump_label_add_module() are currently reported as >> > leaks, though the pointers are stored in the module jump label section. >> > This patch informs kmemleak that this section needs to be scanned. >> > >> > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> >> > Reported-by: Steven Rostedt <rostedt@goodmis.org> >> >> This didn't work. I still get the leak messages. But this change did: >> >> Instead of just picking data sections by name (names that start >> with .data, .bss or .ref.data), use the section flags and scan all >> sections that are allocated, writable and not executable. Which should >> cover all sections of a module that might reference data. >> >> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> > > That's even better. I tested the two patches as well, added a subject > and a bit of clean-up and pushed them to this branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/cmarinas/linux-aarch64.git kmemleak > > Rusty, are you ok to take these or just ack and I'll push them to Linus.
Thanks. I've dropped the original "add .ref.data" patch.
For both patches: Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Cheers, Rusty.
| |