Messages in this thread | | | Date | Thu, 16 May 2013 15:08:29 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v4 7/8] usb: phy: tegra: Add error handling & clean up. |
| |
On 05/16/2013 08:13 AM, Venu Byravarasu wrote: > Check return values from all GPIO APIs and handle errors accordingly. > > Remove the call to clk_disable_unprepare(); this function does not > prepare or enable the clock, so the error path should not disable or > unprepare it. > > Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com> > --- > delta from v3: > Modified comment section to indicate 'otg_ulpi_create returned NULL'.
I'm being really anal here, but note this wasn't a change to a comment, but to the error message printed by the code.
| |