Messages in this thread | | | Date | Thu, 16 May 2013 18:03:12 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space |
| |
On Tue 2013-05-14 01:24:43, Qiaowei Ren wrote: > These interfaces are located in /sys/devices/platform/intel_txt/config, > and including totally 37 files, providing access to Intel TXT > configuration registers.
This looks like very wrong interface... equivalent of /dev/mem.
> +What: /sys/devices/platform/intel_txt/config/STS_raw > +Date: May 2013 > +KernelVersion: 3.9 > +Contact: "Qiaowei Ren" <qiaowei.ren@intel.com> > +Description: TXT.STS is the general status register. This read-only register > + is used by AC modules and the MLE to get the status of various > + Intel TXT features.
This is not enough to allow people to understand what this does/should do, nor does it allow (for example) ARM people to implement something compatible.
Is there specific reason why "better" interface is impossible? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |