lkml.org 
[lkml]   [2013]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] Documentation: allow multiple return statements per function
On 15-05-2013 13:20, Dan Carpenter wrote:
> A surprising number of newbies interpret this section to mean that only
> one return statement is allowed per function. Part of the problem is
> that the "one return statement per function" rule is an actual style
> guideline that people are used to from other projects.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
> index e00b8f0..7fe0546 100644
> --- a/Documentation/CodingStyle
> +++ b/Documentation/CodingStyle
> @@ -389,7 +389,8 @@ Albeit deprecated by some people, the equivalent of the goto statement is
> used frequently by compilers in form of the unconditional jump instruction.
>
> The goto statement comes in handy when a function exits from multiple
> -locations and some common work such as cleanup has to be done.
> +locations and some common work such as cleanup has to be done. If there is no
> +cleanup needed then just return directly.

Agreed with this rephrasing.

>
> The rationale is:
>
>


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-05-16 17:41    [W:0.281 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site