Messages in this thread | | | Date | Thu, 16 May 2013 16:42:05 +0200 | From | John Crispin <> | Subject | Re: [PATCH 31/33] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource |
| |
On 16/05/13 13:15, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang<wsa@the-dreams.de>
Acked-by: John Crispin <blogic@openwrt.org>
> --- > arch/mips/lantiq/xway/gptu.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/mips/lantiq/xway/gptu.c b/arch/mips/lantiq/xway/gptu.c > index 9861c86..d6a79b8 100644 > --- a/arch/mips/lantiq/xway/gptu.c > +++ b/arch/mips/lantiq/xway/gptu.c > @@ -144,10 +144,6 @@ static int gptu_probe(struct platform_device *pdev) > } > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(&pdev->dev, "Failed to get resource\n"); > - return -ENOMEM; > - } > > /* remap gptu register range */ > gptu_membase = devm_ioremap_resource(&pdev->dev, res);
| |