lkml.org 
[lkml]   [2013]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/7] media: davinci: vpif: remove unwanted header includes
Date
Hi Prabhakar,

Thank you for the patch.

On Thursday 16 May 2013 18:28:16 Lad Prabhakar wrote:
> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
> drivers/media/platform/davinci/vpif.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/platform/davinci/vpif.c
> b/drivers/media/platform/davinci/vpif.c index ea82a8b..d354d50 100644
> --- a/drivers/media/platform/davinci/vpif.c
> +++ b/drivers/media/platform/davinci/vpif.c
> @@ -17,18 +17,11 @@
> * GNU General Public License for more details.
> */
>
> -#include <linux/init.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/spinlock.h>
> -#include <linux/kernel.h>
> -#include <linux/io.h>
> -#include <linux/err.h>
> #include <linux/pm_runtime.h>
> #include <linux/v4l2-dv-timings.h>

I think you should keep most of those includes. For instance this file uses
spinlock functions, so linux/spinlock.h should be included. It might work fine
now due to nested includes, but if someone reorganizes the kernel headers
internal includes then the driver might break. As a general rule of good
practice you should include headers for all the APIs you use.

>
> -#include <mach/hardware.h>
> -
> #include "vpif.h"
>
> MODULE_DESCRIPTION("TI DaVinci Video Port Interface driver");
--
Regards,

Laurent Pinchart



\
 
 \ /
  Last update: 2013-05-16 16:21    [W:0.147 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site