lkml.org 
[lkml]   [2013]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] media: i2c: tvp514x: add OF support
Hi Laurent,

On Thu, May 16, 2013 at 6:20 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Hi Prabhakar,
>
> On Thursday 16 May 2013 18:13:38 Prabhakar Lad wrote:
>> On Thu, May 16, 2013 at 5:40 PM, Laurent Pinchart wrote:
>> > Hi Prabhakar,
>>
>> [Snip]
>>
>> >> +
>> >> + pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL);
>> >> + if (!pdata)
>> >
>> > I've started playing with the V4L2 OF bindings, and realized that should
>> > should call of_node_put() here.
>>
>> you were referring of_node_get() here rite ?
>
> No, I'm referring to of_node_put(). The v4l2_of_get_next_endpoint() function
> mentions
>
> * Return: An 'endpoint' node pointer with refcount incremented. Refcount
> * of the passed @prev node is not decremented, the caller have to use
> * of_node_put() on it when done.
>
Ahh I see thanks for clarifying, I'll fix it for v3.

Regards,
--Prabhakar Lad


\
 
 \ /
  Last update: 2013-05-16 15:42    [W:0.068 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site