Messages in this thread | | | Date | Thu, 16 May 2013 11:46:19 +0200 | Subject | Re: [PATCH] drivers: video: mxsfb: clean use of devm_ioremap_resource() | From | Laurent Navet <> |
| |
2013/5/16, Jingoo Han <jg1.han@samsung.com>: > It makes build warning as below: > > drivers/video/mxsfb.c:887:13: warning: 'host' is used uninitialized in this > function [-Wuninitialized] > drivers/video/mxsfb.c:965:21: warning: 'fb_info' may be used uninitialized > in this function [-Wuninitialized] > > It breaks the assignment. > host = to_imxfb_host(fb_info); > > Also, 'goto fb_release;' is not good. > Please use ' return PTR_ERR(host->base);' as below: > + host->base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(host->base)) > + return PTR_ERR(host->base); > > > Best regards, > Jingoo Han
Thank's for reviewing, I'll look at and resend.
Laurent,
| |