lkml.org 
[lkml]   [2013]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 03/15] perf util: Save pid-cmdline mapping into tracing header
Date
On Wed, 15 May 2013 23:21:24 +0200, Jiri Olsa wrote:
> On Tue, May 14, 2013 at 07:13:47PM +0900, Namhyung Kim wrote:
>> +void parse_saved_cmdline(struct pevent *pevent,
>> + char *file, unsigned int size __maybe_unused)
>
> any reason for the size parameter? I can see some other
> functions already following this prototype, but I dont
> see the reason.. just curious ;)

I don't know, but copied those. ;) I guess we can get rid of it.
Steve, any comments?

Thanks,
Namhyung

>
> void parse_ftrace_printk(struct pevent *pevent,
> char *file, unsigned int size __maybe_unused)
>
> void parse_proc_kallsyms(struct pevent *pevent,
> char *file, unsigned int size __maybe_unused)
>
>
> jirka


\
 
 \ /
  Last update: 2013-05-16 05:21    [W:0.118 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site