lkml.org 
[lkml]   [2013]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/PATCH 1/2] perf script: Add --time-filter option
On 5/15/13 7:56 PM, Namhyung Kim wrote:
>> How about just --time? less typing.
>
> Thanks, I'm fine with '--time' too but '--time-filter' looks more

yes, I just have really long command lines now. Is there a consistent
single letter (X?)?

> obvious. What does the timehist command do, btw? ;)

task scheduling time history including run time and time between
sched-in. It needs to be updated to use tracepoints and perhaps fold
into perf-sched (e.g., perf sched history). Too many features; too
little time. I hope to get to it in the next month or so.


>> I would expect parse_nsec_time to fail. e.g., a time string like 123455.a
>
> It looks like current strtol() returns 0 when failed to parse like
> above. Hmm.. do I have to check whether the return value is 0 or just
> ignore invalid inputs?

end will point to the next character not converted so make sure it is as
expected (*end == '\0').

David


\
 
 \ /
  Last update: 2013-05-16 05:21    [W:0.067 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site