Messages in this thread | | | Date | Wed, 15 May 2013 23:20:08 +0200 | From | Sylwester Nawrocki <> | Subject | Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs |
| |
On 05/15/2013 10:31 PM, Heiko Stübner wrote: >>> + BUG(); >> > >> > Isn't that a bit nasty. This macro should be used with care and we >> > should recover if possible. dev_err()? > > runtime_config already denies any settings not in the 1,2 or 4bytes range - > the default-part should therefore never be reached. So if any other value > magically appears in the register and triggers the default-part, something is > seriously wrong. So my guess is, the BUG might be appropriate. > > On the other hand the whole default+BUG part could also simply go away, for > the same reasons.
IMHO BUG() is not needed at all. As Linus suggested dev_err() is such case or WARN_ON() would be more appropriate. This has been discussed in the past extensively, not sure if you are aware of the other Linus' opinion on BUG()/BUG_ON() proliferation: https://lkml.org/lkml/2012/9/27/461
Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |