lkml.org 
[lkml]   [2013]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] nohz: Disable LOCKUP_DETECTOR when NO_HZ_FULL is enabled
From
Date
On Wed, 2013-05-15 at 11:06 -0400, Don Zickus wrote:

> > That's a bit contradictory in function, you want the NMI watchdog to
> > cover all code, so disabling whilst entering NO_HZ state is going to
> > make it not cover some code - *fail*.

Well, when NO_HZ_FULL is set, it covers no code :-)

> >
> > Rather I would suggest disabling the NMI watchdog's runtime default; so
> > you can still enable it with something like:
> >
> > echo 1 > /proc/sys/kernel/nmi_watchdog

Yeah, just disabling it via run time might work.


>
> Coming into the middle of the thread is always hard, but why/how does perf
> disable nohz_full? I didn't think the hardware events of perf would cause
> problems as they are no different than an irq. Curious.

Right now perf requires a tick, not sure exactly why, but you can look
at the code in perf_event_task_tick(). Thus if NO_HZ_FULL sees that a
perf tick is pending, it won't disable ticks. Unfortunately, the
watchdogs, both NMI and soft lockup, use the perf infrastructure to
trigger NMIs or interrupts. This adds a perf element on the rotate list
and keeps NO_HZ_FULL from *ever* activating.

-- Steve




\
 
 \ /
  Last update: 2013-05-15 18:01    [W:0.107 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site