lkml.org 
[lkml]   [2013]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 13/15] clockevents: Provide sysfs interface
On Fri, 26 Apr 2013, Stephen Boyd wrote:

> On 04/25, Thomas Gleixner wrote:
> > Provide a simple sysfs interface for the clockevent devices. Show the
> > current active clockevent device.
> >
>
> Neat. Does this do anything about clockevents that aren't in use
> for the tick devices or broadcast device?

No, but that would be simple to add.

> > +static int tick_broadcast_init_sysfs(void)
>
> __init?

Yes

> > +{
> > + int err = device_register(&tick_bc_dev);
> > +
> > + if (!err)
> > + err = device_create_file(&tick_bc_dev, &dev_attr_current_device);
> > + return err;
> > +}
> > +#else
> > +static struct tick_device *tick_get_tick_dev(struct device *dev)
> > +{
> > + return &per_cpu(tick_cpu_device, dev->id);
> > +}
> > +static inline int tick_broadcast_init_sysfs(void) { return 0; }
> > #endif
> > +
> > +int __init tick_init_sysfs(void)
>
> static?

Yes

> > +{
> > + int cpu;
> > +
> > + for_each_possible_cpu(cpu) {
> > + struct device *dev = &per_cpu(tick_percpu_dev, cpu);
> > + int err;
> > +
> > + dev->id = cpu;
> > + dev->bus = &clockevents_subsys;
> > + err = device_register(dev);
> > + if (!err)
> > + err = device_create_file(dev, &dev_attr_current_device);
> > + if (err)
> > + return err;
> > + }
> > + return tick_broadcast_init_sysfs();
> > +}
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation
>


\
 
 \ /
  Last update: 2013-05-15 12:41    [W:0.212 / U:1.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site