lkml.org 
[lkml]   [2013]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec
On Tue, May 14, 2013 at 08:10:20PM -0700, Nicholas A. Bellinger wrote:
> On Wed, 2013-05-15 at 08:59 +0800, Asias He wrote:
> > scsi.c includes vhost.c which uses memcpy_fromiovec.
> >
> > This patch fixes this build failure.
> >
> > From Randy Dunlap:
> > '''
> > on x86_64:
> >
> > ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi.ko] undefined!
> >
> > It needs to depend on NET since net/core/ provides that function.
> > '''
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Asias He <asias@redhat.com>
>
> Hey Asias & MST,
>
> FYI, I'll be sending a PULL request to Linus in the next couple of days
> for -rc2.
>
> Let me know if you'd like this to be picked up.

Yes, this is 3.10 material. Sounds good to me.

> --nab
>
> > ---
> > drivers/vhost/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
> > index 8b9226d..0403323 100644
> > --- a/drivers/vhost/Kconfig
> > +++ b/drivers/vhost/Kconfig
> > @@ -12,7 +12,7 @@ config VHOST_NET
> >
> > config VHOST_SCSI
> > tristate "VHOST_SCSI TCM fabric driver"
> > - depends on TARGET_CORE && EVENTFD && m
> > + depends on NET && TARGET_CORE && EVENTFD && m
> > select VHOST_RING
> > default n
> > ---help---
>
>

--
Asias


\
 
 \ /
  Last update: 2013-05-15 09:21    [W:0.127 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site