Messages in this thread | | | Date | Wed, 15 May 2013 09:34:36 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] kernel/workqueue.c: kfree issue, need check flag 'WQ_UNBOUND' when processing failure. |
| |
On 05/14/2013 11:20 PM, Tejun Heo wrote: > On Tue, May 14, 2013 at 09:06:40PM +0800, Chen Gang wrote: >> err_destroy: >> destroy_workqueue(wq); >> + if (flags & WQ_UNBOUND) { >> +err_free_wq: >> + free_workqueue_attrs(wq->unbound_attrs); >> + kfree(wq); >> + } > > Doesn't the above make the code free wq twice on after err_destroy? >
Oh, it is my fault. I did not see the put_pwq_unlocked() in details, next I should read the code carefully.
Thanks. -- Chen Gang
Asianux Corporation
| |