Messages in this thread | | | Date | Tue, 14 May 2013 09:09:13 +0200 | Subject | Re: [PATCH] net: ethernet: freescale: use devm_ioremap_resource() | From | Laurent Navet <> |
| |
>> --- a/drivers/net/ethernet/freescale/fec_main.c >> +++ b/drivers/net/ethernet/freescale/fec_main.c >> @@ -1843,8 +1843,6 @@ fec_probe(struct platform_device *pdev) >> pdev->id_entry = of_id->data; >> >> r = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - if (!r) >> - return -ENXIO; >> > > why remove this check?
it's already checked in devm_ioremap_resource in a better way,
void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res) { ... if (!res || resource_type(res) != IORESOURCE_MEM) { dev_err(dev, "invalid resource\n"); return ERR_PTR(-EINVAL); } ...
Laurent.
| |