lkml.org 
[lkml]   [2013]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cgroup: initialize xattr before calling d_instantiate()
On Tue, May 14, 2013 at 07:44:20PM +0800, Li Zefan wrote:
> cgroup_create_file() calls d_instantiate(), which may decide to look
> at the xattrs on the file. Smack always does this and SELinux can be
> configured to do so.
>
> But cgroup_add_file() didn't initialize xattrs before calling
> cgroup_create_file(), which finally leads to dereferencing NULL
> dentry->d_fsdata.
>
> This bug has been there since cgroup xattr was introduced.
>
> Cc: <stable@vger.kernel.org> # 3.8.x
> Reported-by: Ivan Bulatovic <combuster@archlinux.us>
> Reported-by: Casey Schaufler <casey@schaufler-ca.com>
> Signed-off-by: Li Zefan <lizefan@huawei.com>

Applied to cgroup/for-3.10-fixes.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-05-14 18:01    [W:0.026 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site