lkml.org 
[lkml]   [2013]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 6/9] radeon: Switch to arch_phys_wc_add and add a missing ..._del
From
On Tue, May 14, 2013 at 8:58 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
> On Mon, May 13, 2013 at 7:58 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

I believe it will break something but we could deal with the fallout
once it happens.

>> ---
>> drivers/gpu/drm/radeon/radeon_object.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
>> index d3aface..15cd34b 100644
>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>> @@ -321,8 +321,8 @@ void radeon_bo_force_delete(struct radeon_device *rdev)
>> int radeon_bo_init(struct radeon_device *rdev)
>> {
>> /* Add an MTRR for the VRAM */
>> - rdev->mc.vram_mtrr = mtrr_add(rdev->mc.aper_base, rdev->mc.aper_size,
>> - MTRR_TYPE_WRCOMB, 1);
>> + rdev->mc.vram_mtrr = arch_phys_wc_add(rdev->mc.aper_base,
>> + rdev->mc.aper_size);
>> DRM_INFO("Detected VRAM RAM=%lluM, BAR=%lluM\n",
>> rdev->mc.mc_vram_size >> 20,
>> (unsigned long long)rdev->mc.aper_size >> 20);
>> @@ -334,6 +334,7 @@ int radeon_bo_init(struct radeon_device *rdev)
>> void radeon_bo_fini(struct radeon_device *rdev)
>> {
>> radeon_ttm_fini(rdev);
>> + arch_phys_wc_del(rdev->mc.vram_mtrr);
>> }
>>
>> void radeon_bo_list_add_object(struct radeon_bo_list *lobj,
>> --
>> 1.8.1.4
>>


\
 
 \ /
  Last update: 2013-05-14 16:01    [W:0.114 / U:1.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site