Messages in this thread | | | Date | Mon, 13 May 2013 07:53:33 +0100 | From | Srinivas KANDAGATLA <> | Subject | Re: [PATCH v2] regmap: debugfs: Fix start_reg calculation (v2) |
| |
Hi Mark, On 12/05/13 15:59, Mark Brown wrote: > On Wed, May 08, 2013 at 11:20:09AM +0100, Srinivas KANDAGATLA wrote: >> From: Srinivas Kandagatla <srinivas.kandagatla@st.com> >> >> If we dump syscon regmap registers via debugfs you will notice that the >> dump contains lot of XXXXXXXX values. > > Sorry, can you please rebase this against v3.10-rc1? This patch was > against v3.9 and I'm not now convinced that the issue still exists. > I did try 3.10-rc1, and I can not reproduce the issue. very similar patch "regmap: debugfs: Simplify calculation of `c->max_reg'" addressed the issue.
However It looks like one of the return from the regmap_debugfs_get_dump_start() still returns wrong register offset.
<snip> if (from >= c->min && from <= c->max) { fpos_offset = from - c->min; reg_offset = fpos_offset / map->debugfs_tot_len; *pos = c->min + (reg_offset * map->debugfs_tot_len); mutex_unlock(&map->cache_lock); return c->base_reg + reg_offset; } </snip>
Thanks, srini
| |