Messages in this thread | | | Subject | Re: [RFC] teach argv_split() to ignore the spaces surrounded by \e | From | Colin Walters <> | Date | Mon, 13 May 2013 12:06:07 -0400 |
| |
On Mon, 2013-05-13 at 16:35 +0200, Oleg Nesterov wrote:
> Yes, we can change format_corename() to construct "argv" by hand, and > this was my iniital plan. But perhaps it would be better to not uglify > this code even more?
Sure this \e is less code, but it seems pretty ugly to me. Maybe a way to keep fs/coredump.c sane would be always constructing an argv, and then in the !ispipe case just join them into one string.
Though I'm still inclined to change systemd to read /proc/pid/cmdline like abrt does; that way it works on current kernels too.
For what it's worth I noticed this problem with dconf, which uses g_thread_new ("dconf worker", ...), and g_thread_new uses prctl (PR_SET_NAME).
| |