Messages in this thread | | | Date | Sun, 12 May 2013 19:24:46 +0200 | From | Richard Cochran <> | Subject | Re: [PATCH] igb: add a method to get the nic hw time stamping policy |
| |
On Sun, May 12, 2013 at 10:25:55PM +0800, Dong Zhu wrote: > Thanks for your pointing out my mistakes of CodingStyle. > > > > struct hwtstamp_config { > > >+ int rw; > > My initial idea was that the type of rw should be enum like tx_type, but I am > not sure whther it is necessary to define a new enum, if this patch could > be accpeted I will ask someone about the rw. At that time I will change > the type of rw to bool or define a new enum, then convert the if to > switch if necessary.
You cannot add any new field at all. That would break a userland ABI.
Thanks, Richard
| |