Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] linkage.h: fix build breakage due to symbol prefix handling | Date | Thu, 02 May 2013 09:58:08 +0930 |
| |
James Hogan <james.hogan@imgtec.com> writes: > Al's commit e1b5bb6d1236d4ad2084c53aa83dde7cdf6f8eea ("consolidate > cond_syscall and SYSCALL_ALIAS declarations") broke the build on > blackfin and metag due to the following code: > > #ifndef SYMBOL_NAME > #ifdef CONFIG_SYMBOL_PREFIX > #define SYMBOL_NAME(x) CONFIG_SYMBOL_PREFIX ## x > #else > #define SYMBOL_NAME(x) x > #endif > #endif > #define __SYMBOL_NAME(x) __stringify(SYMBOL_NAME(x)) > > __stringify literally stringifies CONFIG_SYMBOL_PREFIX ##x, so you get > lines like this in kernel/sys_ni.s: > > .weak CONFIG_SYMBOL_PREFIXsys_quotactl > .set CONFIG_SYMBOL_PREFIXsys_quotactl,CONFIG_SYMBOL_PREFIXsys_ni_syscall > > The patches in Rusty's modules-next tree such as "CONFIG_SYMBOL_PREFIX: > cleanup." clean up the whole mess around symbol prefixes, so this patch > just attempts to fix the build in the mean time. The intermediate > definition of SYMBOL_NAME above isn't used and is incorrect when > CONFIG_SYMBOL_PREFIX is defined as CONFIG_SYMBOL_PREFIX is a quoted > string literal, so define __SYMBOL_NAME directly depending on > CONFIG_SYMBOL_PREFIX.
I just pushed my modules-next tree to Linus, so hopefully the nightmare is over soon!
Cheers, Rusty.
| |