Messages in this thread | | | Date | Tue, 9 Apr 2013 15:41:37 +0530 | Subject | Re: [PATCH V4 3/4] block: queue work on unbound wq | From | Viresh Kumar <> |
| |
On 9 April 2013 15:28, Amit Kucheria <amit.kucheria@linaro.org> wrote: > On Tue, Apr 9, 2013 at 3:25 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote: >> But how will we know if the user of wq wants to save power or not? He must >> give some flag which is only used when power saving is enabled. We can't >> set WQ_UNBOUND for all wqs. > > You have the Kconfig option + the module param for that. You don't need a flag.
I still don't agree.. Suppose there are three users A, B and C. A wants to use WQ_UNBOUND when POWER_EFFICIENT Kconfig option and module param is enabled. And B always want to enable WQ_UNBOUND and C doesn't want to set WQ_UNBOUND at all..
Now, how will each of these behave differently based on module param settings. B and C are quite clear but A needs a flag for indicating its usage.
| |