lkml.org 
[lkml]   [2013]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V4 3/4] block: queue work on unbound wq
From
On 9 April 2013 15:28, Amit Kucheria <amit.kucheria@linaro.org> wrote:
> On Tue, Apr 9, 2013 at 3:25 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> But how will we know if the user of wq wants to save power or not? He must
>> give some flag which is only used when power saving is enabled. We can't
>> set WQ_UNBOUND for all wqs.
>
> You have the Kconfig option + the module param for that. You don't need a flag.

I still don't agree.. Suppose there are three users A, B and C. A wants to use
WQ_UNBOUND when POWER_EFFICIENT Kconfig option and module param is
enabled. And B always want to enable WQ_UNBOUND and C doesn't want to
set WQ_UNBOUND at all..

Now, how will each of these behave differently based on module param settings.
B and C are quite clear but A needs a flag for indicating its usage.


\
 
 \ /
  Last update: 2013-04-10 15:21    [W:0.076 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site