lkml.org 
[lkml]   [2013]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] thermal: fix frequency table lookup bugs
On 09-04-2013 14:27, Andrew Bresticker wrote:
>> You do two things in this change on cpu_cooling.c: (1) fix the case where
>> the loop is kept running indefinitely. (2) Reserve a specific role for each
>> index in this function.
>
> So the issue is that the changes are not independent. With just the
> fix for the infinite loop, get_cpu_frequency() is still completely
> broken because it is not interpreting the level correctly and will
> return the wrong frequency (and thus not throttling correctly, which
> is bad). Perhaps the commit should be more general, like "fix
> handling of invalid frequency table entries"? What do you think?

It fits better. I am OK if we improve the commit title and description,
providing better explanation of what is the issue (you have done
already) and how what needed to be done to fix it.

>
> Thanks,
> Andrew
>
>



\
 
 \ /
  Last update: 2013-04-09 23:21    [W:1.449 / U:1.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site