Messages in this thread | | | Date | Wed, 10 Apr 2013 07:30:36 +1200 | From | Tony Prisk <> | Subject | Re: [PATCH] pinctrl: vt8500: wmt: Fix checking return value of pinctrl_register() |
| |
On 10/04/13 03:59, Axel Lin wrote: > pinctrl_register() returns NULL on error. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/pinctrl/vt8500/pinctrl-wmt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/vt8500/pinctrl-wmt.c b/drivers/pinctrl/vt8500/pinctrl-wmt.c > index 14400a7..ab63104e 100644 > --- a/drivers/pinctrl/vt8500/pinctrl-wmt.c > +++ b/drivers/pinctrl/vt8500/pinctrl-wmt.c > @@ -588,7 +588,7 @@ int wmt_pinctrl_probe(struct platform_device *pdev, > data->dev = &pdev->dev; > > data->pctl_dev = pinctrl_register(&wmt_desc, &pdev->dev, data); > - if (IS_ERR(data->pctl_dev)) { > + if (!data->pctl_dev) { > dev_err(&pdev->dev, "Failed to register pinctrl\n"); > return -EINVAL; > } Not sure why I missed this...
Linus, If you're happy with this patch, I'll forward it on to arm-soc to go in with the rest.
Regards Tony P
| |