Messages in this thread | | | Date | Tue, 09 Apr 2013 10:20:01 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH v3 3/4] x86, kdump: Change crashkernel_high/low= to crashkernel=;high/low |
| |
On 04/09/2013 10:12 AM, Vivek Goyal wrote: > On Tue, Apr 09, 2013 at 09:49:28AM -0700, H. Peter Anvin wrote: >> On 04/09/2013 09:47 AM, Vivek Goyal wrote: >>> On Tue, Apr 09, 2013 at 08:00:57AM -0700, H. Peter Anvin wrote: >>>> Please, no semicolons. We already have established syntax for suboptions (option=suboption,suboption,...) and suboptions with parameters (option=suboption:value,...) >>> >>> Ok, to understand it better, so crashkernel= will look as follows? >>> >>> crashkernel=suboption[,suboption[,....]][@offset] >>> >>> A suboption can be. >>> >>> - A memory value (128[KMG]) >>> - A range with value (range:size) >>> - Or a property influencing memory allocation behavior (e.g high or low) >>> >>> If yes, sounds good. >>> >> >> Sorry, I don't quite grok @offset and range:size here. > > And @offset means that reserve memory at a particular offset, if > available. >
OK, the @offset should probably be treated as a suboption, with an implicit/optional comma.
Otherwise, makes sense to me.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |