Messages in this thread | | | Date | Tue, 9 Apr 2013 09:10:35 +0200 | From | Samuel Ortiz <> | Subject | Re: [PATCH] mfd: drop "select PMIC_DA9055" |
| |
Hi Paul,
On Sat, Mar 09, 2013 at 05:32:34PM +0100, Paul Bolle wrote: > The Kconfig entry for DA9055 PMIC Support selects PMIC_DA9055. That was > probably inspired by the similar select statement in the entry for > DA9052/53 PMIC with I2C. But the DA9055 PMIC only comes in an I2C > variant and its driver doesn't need a separate Kconfig symbol for shared > code. In any case, this select can be dropped as PMIC_DA9055 doesn't > exist. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > 0) Tested with "git grep" only. > > 1) Note that the DA9052 and DA9055 drivers all have code for module > support, but their Kconfig entries only allow them to be builtin. Can't > these entries be made tristate? If not, shouldn't the code for module > support be removed? > > drivers/mfd/Kconfig | 1 - > 1 file changed, 1 deletion(-) Patch applied to mfd-next, thanks.
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
| |