lkml.org 
[lkml]   [2013]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: pre-clear the returned sockaddr_storage variable
From
Date
On Tue, 2013-04-09 at 10:50 -0700, Kees Cook wrote:
> To avoid future stack content leaks in the various protocols, pre-clear
> the returned memory.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Suggested-by: Brad Spengler <spender@grsecurity.net>
> ---
> net/socket.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index 88f759a..4d2af0d 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -1838,7 +1838,7 @@ SYSCALL_DEFINE6(recvfrom, int, fd, void __user *, ubuf, size_t, size,
> struct socket *sock;
> struct iovec iov;
> struct msghdr msg;
> - struct sockaddr_storage address;
> + struct sockaddr_storage address = { };
> int err, err2;
> int fput_needed;
>
> @@ -2185,7 +2185,7 @@ static int __sys_recvmsg(struct socket *sock, struct msghdr __user *msg,
> int err, total_len, len;
>
> /* kernel mode address */
> - struct sockaddr_storage addr;
> + struct sockaddr_storage addr = { };
>
> /* user mode address pointers */
> struct sockaddr __user *uaddr;
> --
> 1.7.9.5
>
>

Nack, for obvious performance reasons.





\
 
 \ /
  Last update: 2013-04-09 21:01    [W:0.047 / U:1.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site