lkml.org 
[lkml]   [2013]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] bitmap: speedup in bitmap_find_free_region when order is 0
On Mon, 08 Apr 2013 20:18:20 -0700 Joe Perches <joe@perches.com> wrote:

> On Mon, 2013-04-08 at 20:10 -0700, Andrew Morton wrote:
> > > --- a/lib/bitmap.c
> []
> > > + for (i = 0 ; i < nlongs_reg ; i++) {
> >
> > No space before the semicolon, please. checkpatch should warn about
> > this but it seems to be broken.
>
> There's no specific CodingStyle violation here

Let's fix CodingStyle then? Nobody puts spaces before semis - perish
the thought! (I count 4,254,057 versus 8,416 in .c)

> Adding --strict does bleat though.

And let's make it default please.

> # check for whitespace before a non-naked semicolon
> if ($line =~ /^\+.*\S\s+;/) {
> CHK("SPACING",
> "space prohibited before semicolon\n" . $herecurr);
> }
>


\
 
 \ /
  Last update: 2013-04-09 07:02    [W:0.058 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site