lkml.org 
[lkml]   [2013]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/7] spi: spi-fsl-spi: Add support for setting a maximum number of bits per word
On Fri, Feb 15, 2013 at 04:52:25PM +0100, Andreas Larsson wrote:
> Acked-by: Anton Vorontsov <anton@enomsg.org>
> Signed-off-by: Andreas Larsson <andreas@gaisler.com>

I'll apply this on account of it being part of the series and review
having been very slow but...

> /* Make sure its a bit width we support [4..16, 32] */
> if ((bits_per_word < 4)
> - || ((bits_per_word > 16) && (bits_per_word != 32)))
> + || ((bits_per_word > 16) && (bits_per_word != 32))
> + || (bits_per_word > mpc8xxx_spi->max_bits_per_word))
> return -EINVAL;

...we do have support for this in the core now, it would be good to
convert over to that.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-04-09 19:41    [W:0.959 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site